Thanks for the contribution, @pganguli !

@MitchellThompkins, I would appreciate if you could have a brief look at the first two commits related to the test environment.

Thanks for the contribution, @pganguli !

@MitchellThompkins, I would appreciate if you could have a brief look at the first two commits related to the test environment.

I left one comment but otherwise lgtm. I don't work on a SELinux machine so I didn't get bit by the :z thing but that looks like the canonical fix to me per stack overflow.

One thing though @ttl-octave, do you want to merge this into dev or straight into main? It's a minor fix to the local test environment which seems low risk but obviously up to you.

@MitchellThompkins, thanks for reviewing! I totally agree to directly merge this into main.

I don't work on a SELinux machine so I didn't get bit by the :z thing but that looks like the canonical fix to me per stack overflow.

Hi, yeah, I work on Fedora, so I had to fix that issue before I could even run anything using the docker image. I also tested to see if adding :z affects non-SELinux hosts, and it turns out to be a no-op.

I changed the base barnch to main but realized that this would add all the other commits that dev is ahead of main, so switched the base branch back to dev.
@pganguli, could you please rebase your branch misc-fixes to main and update the pull request?

@pganguli, could you please rebase your branch misc-fixes to main and update the pull request?

Done!

If I run the docker via make check-local as my normal user, the installation of the control package fails because pkg tries to create the directory /.lcoal/share/octave... as normal user with missing permissions. If I run it as root (HOST_UID=0 and HOST_GID=0), everything works as expected. Should the docker run as root for the local check?

And another observation: I added 7.3.0 to the builds that are to be tested. This fails on the Github runner (also for 6.4.0) but passes when checking it locally.

If I run the docker via make check-local as my normal user, the installation of the control package fails because pkg tries to create the directory /.lcoal/share/octave... as normal user with missing permissions. If I run it as root (HOST_UID=0 and HOST_GID=0), everything works as expected. Should the docker run as root for the local check?

Okay, it seems that if the user that you are running it under (say, docker) doesn't have an entry under /etc/passwd (thus getting an arbitrary UID), $HOME gets set to / and this problem occurs within the docker image. I'll fix this issue by explicitly setting $HOME to /workspace within the docker image.

And another observation: I added 7.3.0 to the builds that are to be tested. This fails on the Github runner (also for 6.4.0) but passes when checking it locally.

It seems that the relevant logs from the failing build are:

> Run make check-ci
Creating CI package dist directory target/control-4.2.2+-ci ...
  git archive ...
fatal: detected dubious ownership in repository at '/__w/pkg-control/pkg-control'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/pkg-control/pkg-control
fatal: detected dubious ownership in repository at '/__w/pkg-control/pkg-control'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/pkg-control/pkg-control
make: *** [Makefile:152: target/control-4.2.2+-ci] Error 128
Error: Process completed with exit code 2.

As the logs suggest, adding a safe.directory configure step fixes this.

I have opened #38 to fix both these issues. Sorry for the noise and thanks again for testing!